Skip to content

1105 redesign bindings structure to improve typing#1106

Merged
dabele merged 14 commits intomainfrom
1105-redesign-bindings-structure-to-improve-typing
Aug 21, 2024
Merged

1105 redesign bindings structure to improve typing#1106
dabele merged 14 commits intomainfrom
1105-redesign-bindings-structure-to-improve-typing

Conversation

@MaxBetzDLR
Copy link
Copy Markdown
Member

@MaxBetzDLR MaxBetzDLR commented Aug 12, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • test different structures for building the bindings
  • move bindings into subfolder
  • fix bugs in bindings
  • redesign stub generation, so more type hints work

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1105

@MaxBetzDLR MaxBetzDLR linked an issue Aug 12, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (717c026) to head (6120565).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1106   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         135      135           
  Lines       11286    11286           
=======================================
  Hits        10885    10885           
  Misses        401      401           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxBetzDLR MaxBetzDLR marked this pull request as ready for review August 16, 2024 12:48
@MaxBetzDLR MaxBetzDLR requested a review from dabele August 16, 2024 13:10
@MaxBetzDLR MaxBetzDLR self-assigned this Aug 16, 2024
@MaxBetzDLR MaxBetzDLR added loc::python interface This issue concerns the python interface to the backend implementation. class::improvement Cleanup that doesn't affect functionality labels Aug 16, 2024
Comment thread pycode/memilio-simulation/memilio/simulation/abm.py
Comment thread pycode/memilio-simulation/memilio/simulation/bindings/simulation.cpp Outdated
Comment thread pycode/memilio-simulation/setup.py
Comment thread pycode/memilio-simulation/tools/generate_stubs.py Outdated
Comment thread pycode/memilio-simulation/CMakeLists.txt Outdated
@MaxBetzDLR MaxBetzDLR requested a review from dabele August 20, 2024 17:31
Comment thread pycode/memilio-simulation/memilio/simulation/__init__.py
@MaxBetzDLR MaxBetzDLR requested a review from dabele August 21, 2024 13:27
@dabele dabele merged commit 49ee2e8 into main Aug 21, 2024
@dabele dabele deleted the 1105-redesign-bindings-structure-to-improve-typing branch August 21, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::improvement Cleanup that doesn't affect functionality loc::python interface This issue concerns the python interface to the backend implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

redesign bindings structure to improve typing

2 participants