Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
==========================================
- Coverage 97.29% 97.27% -0.03%
==========================================
Files 180 184 +4
Lines 15646 15807 +161
==========================================
+ Hits 15223 15376 +153
- Misses 423 431 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kilianvolmer
left a comment
There was a problem hiding this comment.
Thanks for the fast implementation! It looks overall good to me, I just made some minor remarks, mostly about documentation.
I do, however, have one big question: Which model are you implementing here? I thought you want to implement the Legrande model, but that contains a Hospitalized compartment. Did I get that wrong?
|
Thank you for the fast review :) |
kilianvolmer
left a comment
There was a problem hiding this comment.
Thanks for the quick changes! One small typo and please remove the formatting in the warning/error messages. Then we are ready to merge :)
Co-authored-by: Kilian Volmer <[email protected]>
Co-authored-by: Kilian Volmer <[email protected]>
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
a probability to recover (instead of getting "Removed" from SEIR) with counterprobability to die
a time between dying and getting buried
a probability to infect from dead but not yet buried state D
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)