Skip to content

Fixed problem with undefined variable#1453

Merged
reneSchm merged 1 commit intomainfrom
1452-undefined-variable-in-python-sirs-example
Dec 9, 2025
Merged

Fixed problem with undefined variable#1453
reneSchm merged 1 commit intomainfrom
1452-undefined-variable-in-python-sirs-example

Conversation

@nijawa
Copy link
Copy Markdown
Contributor

@nijawa nijawa commented Dec 8, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • changed days to tmax in simulation function in the sirs python example

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@nijawa nijawa requested a review from MaxBetzDLR December 8, 2025 22:06
@nijawa nijawa self-assigned this Dec 8, 2025
@nijawa nijawa linked an issue Dec 8, 2025 that may be closed by this pull request
2 tasks
@nijawa nijawa requested a review from reneSchm December 8, 2025 22:07
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.30%. Comparing base (9ff64cf) to head (7d2b9af).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1453      +/-   ##
==========================================
- Coverage   97.31%   97.30%   -0.02%     
==========================================
  Files         187      187              
  Lines       16024    16024              
==========================================
- Hits        15594    15592       -2     
- Misses        430      432       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reneSchm
Copy link
Copy Markdown
Member

reneSchm commented Dec 9, 2025

Thank you for finding and fixing this!

@reneSchm reneSchm merged commit 590381f into main Dec 9, 2025
57 checks passed
@reneSchm reneSchm deleted the 1452-undefined-variable-in-python-sirs-example branch December 9, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefined Variable in Python SIRS example

2 participants