Skip to content

1454 Use correct ParameterStudy in graph examples of python bindings#1455

Merged
reneSchm merged 4 commits intomainfrom
1454-update-parameterstudy-in-graph-examples-of-python-bindings
Dec 10, 2025
Merged

1454 Use correct ParameterStudy in graph examples of python bindings#1455
reneSchm merged 4 commits intomainfrom
1454-update-parameterstudy-in-graph-examples-of-python-bindings

Conversation

@reneSchm
Copy link
Copy Markdown
Member

@reneSchm reneSchm commented Dec 9, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm requested a review from MaxBetzDLR December 9, 2025 10:35
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.31%. Comparing base (590381f) to head (2c0b038).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1455      +/-   ##
==========================================
+ Coverage   97.30%   97.31%   +0.01%     
==========================================
  Files         187      187              
  Lines       16024    16024              
==========================================
+ Hits        15592    15594       +2     
+ Misses        432      430       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reneSchm reneSchm added the loc::python interface This issue concerns the python interface to the backend implementation. label Dec 9, 2025
@reneSchm reneSchm self-assigned this Dec 9, 2025
Comment thread pycode/examples/simulation/ode_secir_parameter_study.py
Comment thread pycode/memilio-generation/pyproject.toml
@reneSchm reneSchm requested a review from MaxBetzDLR December 10, 2025 10:34
@reneSchm reneSchm linked an issue Dec 10, 2025 that may be closed by this pull request
2 tasks
@reneSchm reneSchm merged commit 4d31503 into main Dec 10, 2025
@reneSchm reneSchm deleted the 1454-update-parameterstudy-in-graph-examples-of-python-bindings branch December 10, 2025 12:03
@github-project-automation github-project-automation bot moved this from 👀 Review to ✅ Done (Sprint) in MEmilio: Equation-Based-Models Development Dec 10, 2025
@jubicker jubicker moved this from ✅ Done (Sprint) to Done (Total) in MEmilio: Equation-Based-Models Development Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loc::python interface This issue concerns the python interface to the backend implementation.

Projects

Development

Successfully merging this pull request may close these issues.

Update ParameterStudy in graph examples of python bindings

3 participants