Skip to content

1505 Do not include SBML by default#1506

Merged
kilianvolmer merged 1 commit intomainfrom
1505-do-not-include-sbml-by-default
Mar 5, 2026
Merged

1505 Do not include SBML by default#1506
kilianvolmer merged 1 commit intomainfrom
1505-do-not-include-sbml-by-default

Conversation

@reneSchm
Copy link
Copy Markdown
Member

@reneSchm reneSchm commented Mar 5, 2026

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Turn SBML off by default, make package required if on.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm linked an issue Mar 5, 2026 that may be closed by this pull request
2 tasks
@reneSchm reneSchm requested a review from kilianvolmer March 5, 2026 14:21
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.36%. Comparing base (9877cb2) to head (85df713).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   97.38%   97.36%   -0.02%     
==========================================
  Files         188      188              
  Lines       16539    16539              
==========================================
- Hits        16106    16104       -2     
- Misses        433      435       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@kilianvolmer kilianvolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the quick implementation!

@kilianvolmer kilianvolmer merged commit 1bb1c1e into main Mar 5, 2026
70 checks passed
@kilianvolmer kilianvolmer deleted the 1505-do-not-include-sbml-by-default branch March 5, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not include SBML by default

2 participants