Skip to content

688 Add Symptomatic State to ABM#1539

Draft
DavidKerkmann wants to merge 1 commit intomainfrom
688-add-symptomatic-state-to-abm
Draft

688 Add Symptomatic State to ABM#1539
DavidKerkmann wants to merge 1 commit intomainfrom
688-add-symptomatic-state-to-abm

Conversation

@DavidKerkmann
Copy link
Copy Markdown
Member

@DavidKerkmann DavidKerkmann commented Apr 14, 2026

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Change InfectionState to SymtomState. In particular, Susceptible, Exposed, NoSymtpoms and Recovered are now all the same, as they describe a non-symptomatic state.
  • The model logic has not changed much. Some parts have become simpler, checking for an infection has become slightly more difficult.
  • When initializing with random infections, one now has to be careful to correctly initialize, as the Susceptible state is no longer available.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below).
  • New code adheres to coding guidelines.
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP).
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code.
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation and checked in the preview.
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added.
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed.
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.).
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease).
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@DavidKerkmann DavidKerkmann linked an issue Apr 14, 2026 that may be closed by this pull request
2 tasks
@DavidKerkmann DavidKerkmann changed the title Main changes, tests need to be updated 688 Add Symptomatic State to ABM Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Symptomatic State to ABM

1 participant