Conversation
Closed
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 128 128
Lines 10852 10852
=======================================
Hits 10443 10443
Misses 409 409 ☔ View full report in Codecov by Sentry. |
dabele
requested changes
Feb 22, 2024
charlie0614
commented
Mar 11, 2024
Member
Author
charlie0614
left a comment
There was a problem hiding this comment.
Changes according to the review.
dabele
reviewed
Mar 14, 2024
charlie0614
commented
Mar 19, 2024
Member
Author
charlie0614
left a comment
There was a problem hiding this comment.
Added requested changes.
dabele
requested changes
Mar 22, 2024
dabele
requested changes
Apr 5, 2024
dabele
approved these changes
Jun 18, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
Closes #848
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #848