Skip to content

848 scorep profile of abm#942

Merged
dabele merged 20 commits intomainfrom
848-scorep-profile-of-abm
Jun 18, 2024
Merged

848 scorep profile of abm#942
dabele merged 20 commits intomainfrom
848-scorep-profile-of-abm

Conversation

@charlie0614
Copy link
Copy Markdown
Member

@charlie0614 charlie0614 commented Feb 20, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • add usage documentation and filter for performance measuring with scorep
  • add possibility to enable and disable warnings as errors in cmake

Closes #848

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #848

@charlie0614 charlie0614 added class::documentation Improvements or additions to documentation model::abm This issue concerns any kind of agent-based model. labels Feb 20, 2024
@charlie0614 charlie0614 requested a review from dabele February 20, 2024 12:54
@charlie0614 charlie0614 self-assigned this Feb 20, 2024
@charlie0614 charlie0614 linked an issue Feb 20, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (0c73489) to head (584ac3d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #942   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         128      128           
  Lines       10852    10852           
=======================================
  Hits        10443    10443           
  Misses        409      409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread cpp/benchmarks/filter-main
Comment thread cpp/benchmarks/scorep_measuring.md
Comment thread cpp/benchmarks/scorep_measuring.md
Comment thread cpp/benchmarks/scorep_measuring.md
Comment thread cpp/benchmarks/scorep_measuring.md Outdated
Comment thread cpp/benchmarks/scorep_measuring.md Outdated
Comment thread cpp/benchmarks/scorep_measuring.md Outdated
Comment thread cpp/benchmarks/scorep_measuring.md
Comment thread cpp/cmake/BuildBoost.cmake Outdated
Comment thread cpp/simulations/abm.cpp Outdated
Copy link
Copy Markdown
Member Author

@charlie0614 charlie0614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes according to the review.

Comment thread cpp/benchmarks/scorep_measuring.md
Comment thread cpp/benchmarks/scorep_measuring.md
Comment thread cpp/benchmarks/scorep_measuring.md
Comment thread cpp/benchmarks/scorep_measuring.md Outdated
Comment thread cpp/benchmarks/scorep_measuring.md Outdated
Comment thread cpp/benchmarks/scorep_measuring.md Outdated
Comment thread cpp/benchmarks/scorep_measuring.md
Comment thread cpp/cmake/BuildBoost.cmake Outdated
Comment thread cpp/benchmarks/filter-main
Comment thread cpp/simulations/abm.cpp Outdated
Comment thread cpp/CMakeLists.txt Outdated
Comment thread cpp/CMakeLists.txt Outdated
Comment thread cpp/benchmarks/scorep_measuring.md
Comment thread cpp/benchmarks/scorep_measuring.md Outdated
Copy link
Copy Markdown
Member Author

@charlie0614 charlie0614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added requested changes.

Comment thread cpp/CMakeLists.txt Outdated
Comment thread cpp/CMakeLists.txt Outdated
Comment thread cpp/benchmarks/scorep_measuring.md
Comment thread cpp/cmake/BuildBoost.cmake Outdated
Comment thread cpp/benchmarks/scorep_measuring.md Outdated
Comment thread cpp/CMakeLists.txt
Comment thread cpp/CMakeLists.txt Outdated
Comment thread cpp/CMakeLists.txt Outdated
@dabele dabele merged commit 9022c7c into main Jun 18, 2024
@dabele dabele deleted the 848-scorep-profile-of-abm branch June 18, 2024 07:37
@dabele dabele mentioned this pull request Jun 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::documentation Improvements or additions to documentation model::abm This issue concerns any kind of agent-based model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ScoreP Profile of ABM

2 participants