add saveat to SimpleTauLeaping, fix allocations, improve tests#550
Merged
isaacsas merged 2 commits intoSciML:masterfrom Feb 14, 2026
Merged
add saveat to SimpleTauLeaping, fix allocations, improve tests#550isaacsas merged 2 commits intoSciML:masterfrom
isaacsas merged 2 commits intoSciML:masterfrom
Conversation
- Add `saveat` keyword to SimpleTauLeaping solver, matching SimpleExplicitTauLeaping's interface. When provided, only the requested times are stored instead of every dt step. - Replace per-step allocation (du + uprev) with pre-allocated buffer swap (u_new .= du .+ uprev) for zero inner-loop allocations. - Fix duplicate initial time bug in SimpleExplicitTauLeaping's save_idx initialization when saveat includes t0. - Restore Nsims=1000 in regular_jumps tests with proper memory control: save_positions=(false,false) for SSAStepper, saveat for all solvers, direct sol[i].u[j] indexing instead of interpolation. - Add "Saving Controls" testset verifying saveat behavior for SSAStepper, SimpleTauLeaping, and SimpleExplicitTauLeaping. Co-Authored-By: Claude Opus 4.5 <[email protected]>
…ct filtering Follow OrdinaryDiffEq conventions for saveat processing: - Filter saveat to strictly interior times using binary search - Resolve save_start/save_end defaults based on endpoint membership - Sort unordered saveat collections, filter out-of-range times - Remove fragile isapprox checks for duplicate t0 detection Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
saveatkeyword to SimpleTauLeaping solver, matching SimpleExplicitTauLeaping's interface. When provided, only the requested times are stored instead of every dt step.