fix VR_Direct/FW type instability, reduce gene expr test variants#552
Merged
isaacsas merged 1 commit intoSciML:masterfrom Feb 16, 2026
Merged
fix VR_Direct/FW type instability, reduce gene expr test variants#552isaacsas merged 1 commit intoSciML:masterfrom
isaacsas merged 1 commit intoSciML:masterfrom
Conversation
Cache gauss_points/gauss_weights as module-level const to fix type instability from non-const globals in DiffEqCallbacks. Add loop-based cumsum_rates! for AbstractVector to avoid dynamic splatting in VR_DirectFW. Reduce gene expr test variants: test use_stepper=false and Float64 u0 with subset of algorithms, use init/reinit!/solve! pattern in runSSAs_ode. Gene expr test: 543s → 125s (4.4×), 15.36G → 73M allocs (210×). Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache gauss_points/gauss_weights as module-level const to fix type instability from non-const globals in DiffEqCallbacks. Add loop-based cumsum_rates! for AbstractVector to avoid dynamic splatting in VR_DirectFW. Reduce gene expr test variants: test use_stepper=false and Float64 u0 with subset of algorithms, use init/reinit!/solve! pattern in runSSAs_ode.
Gene expr test: 543s → 125s (4.4×), 15.36G → 73M allocs (210×).