Fix VR_FRM initialize: use u_modified!(true) #558
Merged
isaacsas merged 2 commits intoSciML:masterfrom Feb 24, 2026
Merged
Conversation
…rator The VR_FRM callback initialization sets jump_u = -randexp(), which modifies part of the ODE state vector. Previously this used u_modified!(false) with manual uprev sync as a workaround for a spurious save at t=0. The correct fix is u_modified!(true) and updating tests to handle the initialization save point. - Remove manual uprev.jump_u sync (OrdinaryDiffEqCore handles it) - Update first_jump_time helpers to use findfirst(>) for robustness - Add missing `using Test` to thread_safety.jl Co-Authored-By: Claude Opus 4.5 <[email protected]>
The u_modified!(true) change causes an extra save at t=0, so skip all t=0 entries when checking post-jump values instead of hardcoding u[3:end]. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VR_FRM callback initialization sets jump_u = -randexp(), which modifies part of the ODE state vector. Previously this used u_modified!(false) with manual uprev sync as a workaround for a spurious save at t=0. The correct fix is u_modified!(true) and updating tests to handle the initialization save point.
using Testto thread_safety.jl