Fix reset_aggregated_jumps! kwarg dispatch for SSAIntegrator (#562)#565
Merged
isaacsas merged 5 commits intoSciML:masterfrom Mar 18, 2026
Merged
Conversation
The SSAIntegrator-specific method did not accept kwargs, so calling reset_aggregated_jumps!(int; update_jump_params=true) dispatched to the generic method which uses integrator.opts.callback (empty for SSAStepper) instead of integrator.cb. Forward kwargs through the SSAIntegrator method. Co-Authored-By: Claude Opus 4.5 <[email protected]>
ChrisRackauckas
approved these changes
Mar 10, 2026
Member
Author
|
@ChrisRackauckas seems to be another new ambiguity error. I assume this is temporary till the integrator unification stuff is done? |
OrdinaryDiffEqCore added AbstractJumpProblem to its __init Union type, creating a method ambiguity with JumpProcesses' __init. Add a package extension that defines a more specific method for OrdinaryDiffEqAlgorithm and DAEAlgorithm to resolve the dispatch conflict. Co-Authored-By: Claude Opus 4.5 <[email protected]>
OrdinaryDiffEq v6.106+ requires OrdinaryDiffEqCore v3. The old compat bound (1.32.0) prevented the resolver from picking up v3.22.0, which is the version that introduced the AbstractJumpProblem union in __init. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add lmul!(::AbstractQ, ::ExtendedJumpArray) needed by LinearSolve's QR factorization path (broke in LinearSolve v3.66.0). Fix existing ldiv! which created a temporary but never wrote results back to the ExtendedJumpArray fields. Update docs Catalyst compat to v16. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Replace DiscreteProblem(rn, ...) + JumpProblem(rn, prob, ...) with the new JumpProblem(rn, u0, tspan, p) constructor. Update Catalyst compat to v16 in both docs Project.toml files. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #562