Skip to content

Remove unused FastBroadcast weak dependency #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 2 commits into from
Apr 1, 2026
+2 −11
Merged

Remove unused FastBroadcast weak dependency #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
430151f
Remove unused FastBroadcast weak dependency
ChrisRackauckas Apr 1, 2026
d24beef
Restore FastBroadcast test dep, only remove from [weakdeps]
ChrisRackauckas Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ SymbolicIndexingInterface = "2efcf032-c050-4f8e-a9bb-153293bab1f5"

[weakdeps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
FastBroadcast = "7034ab61-46d4-4ed7-9d0f-46aef9175898"
KernelAbstractions = "63c18a36-062a-441e-b654-da1e3ab1ce7c"
OrdinaryDiffEqCore = "bbf590c4-e513-4bbe-9b18-05decba2e5d8"

Expand Down Expand Up @@ -79,4 +78,4 @@ StochasticDiffEq = "789caeaf-c7a9-5a7d-9973-96adeb23e2a0"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["ADTypes", "Aqua", "ExplicitImports", "LinearAlgebra", "LinearSolve", "OrdinaryDiffEq", "Pkg", "SafeTestsets", "StableRNGs", "Statistics", "StochasticDiffEq", "Test", "FastBroadcast"]
test = ["ADTypes", "Aqua", "ExplicitImports", "FastBroadcast", "LinearAlgebra", "LinearSolve", "OrdinaryDiffEq", "Pkg", "SafeTestsets", "StableRNGs", "Statistics", "StochasticDiffEq", "Test"]
10 changes: 1 addition & 9 deletions benchmarks/extended_jump_array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This file is not directly included in a test case, but is used to
# benchmark and compare changes to the broadcsting
using JumpProcesses, StableRNGs, FastBroadcast, BenchmarkTools
using JumpProcesses, StableRNGs, BenchmarkTools

rng = StableRNG(123)

Expand All @@ -13,15 +13,7 @@ function test_single_dot(out, array)
@inbounds @. out = array + 1.23 * array
end

function test_double_dot(out, array)
@inbounds @.. out = array + 1.23 * array
end

println("Base-case normal broadcasting")
@benchmark test_single_dot(base_case_out, base_case_in)
println("EJA normal broadcasting")
@benchmark test_single_dot(benchmark_out, benchmark_in)
println("Base-case fast broadcasting")
@benchmark test_double_dot(base_case_out, base_case_in)
println("EJA fast broadcasting")
@benchmark test_double_dot(benchmark_out, benchmark_in)
Loading