Add nm_bool to dia_init and add sptype switch to sparse_to_nmatrix and typo fix#17
Closed
Uditgulati wants to merge 2 commits intoSciRuby:masterfrom
Closed
Add nm_bool to dia_init and add sptype switch to sparse_to_nmatrix and typo fix#17Uditgulati wants to merge 2 commits intoSciRuby:masterfrom
Uditgulati wants to merge 2 commits intoSciRuby:masterfrom
Conversation
Member
Author
|
@prasunanand I've changed some elements arrays' data types to void*, so that any type can be assigned to it. This will prevent the nesting of dtpe and sptype switch statements. Also, I think we can take out some common code in nm_sparse_to_nmatrix and nm_sparse_to_array to a separate function. This will reduce code repetition. What do you think? |
Member
Author
|
@prasunanand void* as function parameter did not work. I found 2 possible solutions to this. One is using an enum structure for types. Second is to make the function as a macro and pass the type. |
Member
|
Please write code and explain in this thread. |
Member
|
keep it on hold, currently. |
Member
Author
|
Part of #21. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.