Skip to content

Assignment one#1

Open
Sdong23 wants to merge 19 commits intomainfrom
assignment-one
Open

Assignment one#1
Sdong23 wants to merge 19 commits intomainfrom
assignment-one

Conversation

@Sdong23
Copy link
Copy Markdown
Owner

@Sdong23 Sdong23 commented Jan 27, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

adding code and figure

What did you learn from the changes you have made?

practice and learn

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

no

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

yes, some codes do not work. searched for a solution.

How were these changes tested?

run remotely

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

SELECT *
FROM vendor
INNER JOIN vendor_booth_assignments
ON vendor.vendor_id = vendor_booth_assignments.vendor_id
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using table alias to shorten the query and improve readability.

Copy link
Copy Markdown

@kelichiu kelichiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point: 30/30

Section 1: ✅ Complete

Section 2: ✅ Complete

Section 3: ✅ Complete

Section 4: ✅ Complete

  • The reflection is both thoughtful and insightful, I enjoyed reading it.
  • Making codes easy to read is an undermined but essential skill, I appreciate that you made the effort to format your codes.
  • Please see additional comment(s) in assignment1.sql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants