Open
Conversation
…us- tomer table, sorted by customer_last_name, then customer_first_ name. */
…d column 'price' (quantity * cost_to_customer_per_qty), filtered by vendor IDs between 8 and 10
columns and add a column called prod_qty_type_condensed that displays the word “unit” if the product_qty_type is “unit,” and otherwise displays the word “bulk.”
…1 if the product_name contains the word “pepper”
…assignment-one
kelichiu
reviewed
Jan 27, 2025
| SELECT * | ||
| FROM vendor | ||
| INNER JOIN vendor_booth_assignments | ||
| ON vendor.vendor_id = vendor_booth_assignments.vendor_id |
There was a problem hiding this comment.
Consider using table alias to shorten the query and improve readability.
kelichiu
approved these changes
Jan 27, 2025
kelichiu
left a comment
There was a problem hiding this comment.
Point: 30/30
Section 1: ✅ Complete
Section 2: ✅ Complete
Section 3: ✅ Complete
Section 4: ✅ Complete
- The reflection is both thoughtful and insightful, I enjoyed reading it.
- Making codes easy to read is an undermined but essential skill, I appreciate that you made the effort to format your codes.
- Please see additional comment(s) in assignment1.sql.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
adding code and figure
What did you learn from the changes you have made?
practice and learn
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
no
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
yes, some codes do not work. searched for a solution.
How were these changes tested?
run remotely
A reference to a related issue in your repository (if applicable)
Checklist