Introduce greaseBeginsWith: and greaseEndsWith:#157
Merged
Conversation
added 7 commits
February 5, 2023 12:01
…favor of the new `greaseBeginsWith:` and `greaseEndsWith:`
Codecov ReportBase: 85.59% // Head: 84.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 85.59% 84.48% -1.12%
==========================================
Files 1837 2017 +180
Lines 12373 13570 +1197
==========================================
+ Hits 10591 11464 +873
- Misses 1782 2106 +324
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Feb 5, 2023
Member
Author
|
@marschall What do you think? |
Contributor
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of removing the tests in #149, I propose adding new methods that define the new behaviour across all platforms consistenty. See discussion in #147.
In summary:
greaseBeginsWith:andgreaseEndsWith:onSequenceableCollectionwhich implements the semantics ofbeginsWith:andendsWith:such that using an empty argument collections always returnstrue. This is different from the currentbeginsWithSubCollection:andendsWithSubCollection:which returnfalsewhen used with an empty argument.beginsWithSubCollection:andendsWithSubCollection: