Skip to content

Slime renovation#167

Merged
jbrichau merged 21 commits intomasterfrom
slime-renovation
Jan 14, 2024
Merged

Slime renovation#167
jbrichau merged 21 commits intomasterfrom
slime-renovation

Conversation

@jbrichau
Copy link
Member

@jbrichau jbrichau commented Jan 13, 2024 •
edited
Loading

Slime rules for Pharo 11 and higher:

  • Removed obsolete rules:
    • GREmptyStatementRule is superseded in Pharo by ReMultiplePeriodsTerminatingStatementRule
    • Literal byte arrays are now supported across all supported dialects, so we removed this rule
  • Ported implementation to Renraku critiques framework
  • Improvements to rules to show critiques in the code browser

Johan Brichau added 18 commits September 11, 2023 18:59
GREmptyStatementRule is superseded in Pharo by ReMultiplePeriodsTermi…
eef7478 
…natingStatementRule
Literal byte arrays are accepted in Pharo, GemStone and VAST
8bd356e
Merge branch 'master' into slime-renovation
b6ee952
First couple of Slime rules and tests converted to Reraku critiques
1a385fc
Correct baseline typo
98f2c5c
Remove obsolete tests from older Slime test package as well
171232f
Fix another baseline typo
d6705ff
ported rules: invalid object initialization and non-portable messages
81bec5c
Ported Slime rule for referencing/using a non-portable class
2800c45
Block and Parens formatting rules moved to the PharoWithStyle project…
1c02177 
…; removed the curly braces rule since it is not applicable anymore
Moved the return and temps formatting rules to the PharoWithStyle pro…
18a37b0 
…ject
Two more Slime rules ported
e34bcc2
Ported ANSI Booleans transformation Slime rule
002bf2e
fix
1ec525d
Ported all transformation Slime rules
59552a5
Change class names back to previous class names (i.e. 'GRReXXX' to 'G…
1031a70 
…RXXX')
Fix ANSI characters Slime rule
bfea7ea
Fix ANSIStrings Slime rule
4990652
@codecov
Copy link

codecov bot commented Jan 13, 2024 •
edited
Loading

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (b0307c4) 84.75% compared to head (4e5cec2) 84.96%.

Files Patch % Lines
...RTestAssertionsRule.class/instance/checkMethod..st 0.00% 7 Missing ⚠️
....package/GRReSlimeTest.class/instance/canParse..st 0.00% 7 Missing ⚠️
...package/GRAnsiBooleansRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ckage/GRAnsiCharactersRule.class/instance/group.st 0.00% 4 Missing ⚠️
...kage/GRAnsiCollectionsRule.class/instance/group.st 0.00% 4 Missing ⚠️
...age/GRAnsiConditionalsRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ackage/GRAnsiConvertorRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ckage/GRAnsiExceptionsRule.class/instance/group.st 0.00% 4 Missing ⚠️
....package/GRAnsiStreamsRule.class/instance/group.st 0.00% 4 Missing ⚠️
....package/GRAnsiStringsRule.class/instance/group.st 0.00% 4 Missing ⚠️
... and 15 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   84.75%   84.96%   +0.21%     
==========================================
  Files        1923     2038     +115     
  Lines       13092    13983     +891     
==========================================
+ Hits        11096    11881     +785     
- Misses       1996     2102     +106

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau merged commit 59b1042 into master Jan 14, 2024
@jbrichau jbrichau deleted the slime-renovation branch January 14, 2024 10:34
@jbrichau jbrichau mentioned this pull request Jan 14, 2024
Closed
@jbrichau jbrichau mentioned this pull request Feb 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jbrichau