Open
Conversation
dwz92
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I populated the assignment_1.ipynb file with my code for a standard anagram checker and then tweaked the checker to take into account case sensitivity.
What did you learn from the changes you have made?
I learned that when defining a function the order of commands matters. For instance, if you are using the sort function and applying a method on the same string variables, the method has to be defined first because the output of the sort function is a list and methods can only be used on strings.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
n/a
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I had some challenges altering the original code to check for case sensitivity. I over came this by asking for some help and by breaking down the logic into plain english sentences that made sense to me before going back to re-order the code.
How were these changes tested?
I confirmed these changes by calling the function I defined to se if it would give the expected output for both true and false case sensitive scenarios.
A reference to a related issue in your repository (if applicable)
n/a
Checklist