Address review feedback: remove test scaffolding and fix formatting#5
Closed
Copilot wants to merge 2 commits intorevamp-projectfrom
Closed
Address review feedback: remove test scaffolding and fix formatting#5Copilot wants to merge 2 commits intorevamp-projectfrom
Copilot wants to merge 2 commits intorevamp-projectfrom
Conversation
Merged
…olchain Co-authored-by: Katze719 <[email protected]>
Copilot
AI
changed the title
[WIP] Revamp project with C++23 module support
Address review feedback: remove test scaffolding and fix formatting
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed review comments to clean up the CMake configuration and remove test files that were testing CMake's module behavior rather than library code.
Removed test infrastructure
test/hello.cxxandtest/main.cppmodule test fileshello_module,module_test,copy-compile-commands)CMAKE_EXPORT_COMPILE_COMMANDSand module-related variables from main CMakeLists.txtUpdated MSVC toolchain
add_definitions()toadd_compile_definitions()for modern CMakeCMAKE_SYSTEM_NAMEtoGenericfor consistency with GCC/Clang toolchainsStandardized formatting
project()command structure and descriptioninstall()commands✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.