Open
Conversation
pedram-aliniaye-asli
approved these changes
Sep 14, 2024
pedram-aliniaye-asli
left a comment
There was a problem hiding this comment.
You did a great job here!
Please go ahead and close this pull request now. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I completed functions to read CSV files and calculate mean, max, min values for each patient in the corresponding file.
What did you learn from the changes you have made?
I learned about functions, their arguments, and how they return values. I also learned about reading files.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I considered the possibility of reading files row by row without .readlines method by using only a for loop.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
First I didn't know what would be the output of np.loadtxt(), which I tested in the terminal and got myself familiar with it.
How were these changes tested?
Through the jupyter notebook as well as executing some codes in terminal to to ensure it produced the correct output.
A reference to a related issue in your repository (if applicable)
N/A
Checklist