Merged
Conversation
zivy
approved these changes
Feb 18, 2025
Member
zivy
left a comment
There was a problem hiding this comment.
Does the new .clang-format configuration file match the ITK clang settings? I suspect this update is intended to keep the SimpleITK C++ style consistent with ITK? If so, indicate this in the commit message or possibly in the header of the config file?
If this isn't the case, then just ignore this comment. Always good to have a consistent styling tool run on the code.
Additional updates to pre-commit hooks. Add clang format configuration from ITK's current development.
6fee755 to
713078e
Compare
Member
Author
|
Yes, the .clang-format file comes for ITK. I updates the commit message. |
dave3d
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clang format file it copied from ITK.