Merged
Conversation
zivy
reviewed
Feb 18, 2025
Member
zivy
left a comment
There was a problem hiding this comment.
Not sure if moving away from explicit installation of pre-commit to the pre-commit action is the right thing to do. Specifically, the pre-commit action README says "this action is in maintenance-only mode".
Possibly it doesn't matter as the action is doing what the deleted configuration does, so doesn't matter that it isn't updated and only maintained in working order?
dave3d
approved these changes
Feb 18, 2025
5dfed40 to
c3a5ba1
Compare
Based on the pre-commit actions that is not favored.
c3a5ba1 to
6a758e8
Compare
zivy
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.