1212
Adress failing Doxygen builds in Packaging CI by blowekamp · Pull Request #2243 · SimpleITK/SimpleITK · GitHub
Skip to content

Adress failing Doxygen builds in Packaging CI#2243

Merged
blowekamp merged 1 commit intoSimpleITK:masterfrom
blowekamp:refactor_csvtotable
Feb 21, 2025
Merged

Adress failing Doxygen builds in Packaging CI#2243
blowekamp merged 1 commit intoSimpleITK:masterfrom
blowekamp:refactor_csvtotable

Conversation

@blowekamp
Copy link
Copy Markdown
Member

@blowekamp blowekamp commented Feb 21, 2025

Updated script to follow modern python conventions. Fixed issues with using legacy python 2 string and print syntax.

@blowekamp
Refactor script fixing various python 3+ bugs
ab62953 
Updated script to follow modern python conventions. Fixed issues with
using legacy python 2 string and print syntax.
@blowekamp blowekamp requested review from dave3d and zivy February 21, 2025 14:32
dave3d
dave3d approved these changes Feb 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dave3d dave3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black would reformat this file a bit.

@blowekamp
Copy link
Copy Markdown
Member Author

blowekamp commented Feb 21, 2025 •
edited
Loading

We have black running as a pre-commit and in the CI, so it shouldn't... But I'll double check.

Passes:
.git/hooks/venv/bin/pre-commit run --files Utilities/*.py
detect private key.......................................................Passed
forbid submodules....................................(no files to check)Skipped
check for case conflicts.................................................Passed
check illegal windows names..........................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
black....................................................................Passed
clang-format.........................................(no files to check)Skipped
Check version of SetupForDevelopment.....................................Passed
kw-pre-commit............................................................Passed
forbid txx extensions................................(no files to check)Skipped

@blowekamp blowekamp merged commit e47940e into SimpleITK:master Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dave3d dave3d dave3d approved these changes

@zivy zivy Awaiting requested review from zivy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blowekamp @dave3d