Update JSONBeautify Python script.#2326
Merged
blowekamp merged 1 commit intoSimpleITK:masterfrom Jun 16, 2025
Merged
Conversation
Change separator to match pre-commit configuration. Add argparse interface to support multiple json file on the command line, and different verbosity levels.
zivy
approved these changes
Jun 16, 2025
|
|
||
| # Write beautified JSON back to the file | ||
| with open(json_file, 'w', encoding='utf-8') as fp: | ||
| json.dump(json_data, fp, indent=args.indent, separators=(",", ": "), ensure_ascii=False) |
Member
There was a problem hiding this comment.
What is the reason for changing the default ensure_ascii from True to False? Are there non-ascii characters in the JSON files that should not be escaped?
Member
Author
There was a problem hiding this comment.
There are non-ascii characters in the JSON. In the documentation strings from ITK as I recall. I am unaware of a need for them to be escaped. In general we can use UTF-8 character encoding for text files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change separator to match pre-commit configuration.
Add argparse interface to support multiple json file on the command line, and different verbosity levels.