BUG: Remove '%' from tmp file names#2432
Merged
blowekamp merged 1 commit intoSimpleITK:mainfrom Sep 24, 2025
Merged
Conversation
When passing an image file to ImageJ, it does not like '%' in the file name. If the ImageViewer has a title, the file name is derived from it.
zivy
approved these changes
Sep 23, 2025
blowekamp
approved these changes
Sep 23, 2025
| @@ -954,16 +955,14 @@ FormatFileName(const std::string & TempDirectory, | |||
| if (!name.empty()) | |||
| { | |||
| std::string n = name; | |||
Member
There was a problem hiding this comment.
It took me a moment to figure out the erase remove idiom below:
https://en.wikipedia.org/wiki/Erase–remove_idiom
But if I understand it, since you are constructing the string here you can do something like
std::string n(name.begin(), std::remove_if(n.begin(), n.end(), &IsBadCharacter), n.end());
But tangental to the PR.
Member
Author
There was a problem hiding this comment.
Yeah, looking at this old code it's not the way I'd do it now, but oh well.
Also, I tried out every other non-alphanumeric character and ImageJ didn't have problems with them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing an image file to ImageJ, it does not like '%' in the file name. If the ImageViewer has a title, the file name is derived from it.