Update Elastix to Superbuild 5.3.1#2540
Merged
blowekamp merged 2 commits intoSimpleITK:mainfrom Mar 27, 2026
Merged
Conversation
This name was equivalent to "bspline" which is already being tested.
blowekamp
commented
Mar 26, 2026
| EXPECT_NO_THROW(resultImage = silx.GetResultImage()); | ||
| EXPECT_FALSE(silxIsEmpty(resultImage)); | ||
|
|
||
| EXPECT_NO_THROW(silx.SetParameterMap(GetDefaultParameterMap("nonrigid"))); |
Member
Author
There was a problem hiding this comment.
@N-Dekker Did I understand correctly that "nonrigid" transform name here was just an alias to bspline? and not it is removed?
Collaborator
There was a problem hiding this comment.
@blowekamp The transform name "nonrigid" was indeed just an alias of "bspline" We removed "nonrigid" by:
- pull request STYLE: Drop support ParameterObject::GetDefaultParameterMap("nonrigid") SuperElastix/elastix#1359 commit SuperElastix/elastix@2514029, included with elastix 5.3.0 and 5.3.1.
An attempt to use "nonrigid" should now trigger an "expected" exception.
Member
Author
There was a problem hiding this comment.
Are you recommending just switching this to EXPECT_THROW? or good as is?
Collaborator
There was a problem hiding this comment.
I think it's OK to just remove the whole section that checks the "nonrigid" transform. Good as is 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.