Test packaging SimpleITK with Elastix#2544
Draft
blowekamp wants to merge 7 commits intoSimpleITK:mainfrom
Draft
Conversation
Builds SimpleElastix Python 3.11 wheels (limited API) with SimpleITK_USE_ELASTIX enabled. No source archives, no doxygen, no publishing. Renames output wheels from SimpleITK to SimpleElastix.
7 tasks
e73886b to
2e72788
Compare
Add a package-docker job building manylinux wheels for all four matrix entries (x86_64 and aarch64, manylinux2014 and manylinux2-28) with SimpleITK_USE_ELASTIX enabled and Python 3.11 limited API only. Output wheels are renamed from SimpleITK to SimpleElastix. Update cmd.sh to conditionally pass -DSimpleITK_USE_ELASTIX:BOOL=ON to the SuperBuild cmake when the SIMPLEITK_USE_ELASTIX env var is set. This is backwards-compatible; existing Package.yml builds are unaffected. Use CMake 4.2.0 in GHA
3a288b0 to
fbc0fc1
Compare
Member
Author
|
This appears to be working. If anyone tests an artifact then please report if it works for you or not. |
Add a CMake cache variable SimpleITK_PYTHON_PACKAGE_NAME (default "SimpleITK") to allow the Python package to be built under an alternate name such as SimpleElastix. - Use the variable for SWIG output directory, install destinations, and configured file paths in Wrapping/Python/CMakeLists.txt - Use lowercase variant in pyproject.toml.in for the PyPI package name - Switch Python source files to relative imports so they work regardless of the package directory name - Install a SimpleITK compatibility shim into the test virtualenv when the package is renamed, so "import SimpleITK" still works
fbc0fc1 to
6aa6ae6
Compare
Add a ctest_test_exclude input to the package_python composite action that allows callers to specify a regex pattern for excluding tests from ctest_test. When set, the CTEST_TEST_ARGS environment variable is constructed with EXCLUDE;<pattern> which is passed through github_actions.cmake to ctest_test() in simpleitk_common.cmake. Use this in ElastixPackage.yml to exclude Python.Test(ArrayView| ImageBuffer|Numpy) tests that fail because the package is named SimpleElastix instead of SimpleITK.
When PYTHON_VERSIONS is empty the docker build script builds for all supported Python versions rather than a single specified version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.