Fix continue-on-error in composite actions to use boolean expression#2557
Merged
blowekamp merged 1 commit intoSimpleITK:mainfrom Apr 11, 2026
Merged
Fix continue-on-error in composite actions to use boolean expression#2557blowekamp merged 1 commit intoSimpleITK:mainfrom
blowekamp merged 1 commit intoSimpleITK:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates composite GitHub Actions so continue-on-error evaluates as a proper boolean (instead of a truthy/falsey string), preventing "false" from being treated as enabled.
Changes:
- Set
continue-on-errorinput defaults to the string'false'where needed. - Update
continue-on-errorusage to a boolean expression:${{ inputs.continue-on-error == 'true' }}across Python/Java/CSharp packaging actions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/actions/package_python/action.yml | Uses boolean expression for continue-on-error and makes its default a string. |
| .github/actions/package_java/action.yml | Adds string default for continue-on-error and compares to 'true' to produce a boolean. |
| .github/actions/package_csharp/action.yml | Adds string default for continue-on-error and compares to 'true' to produce a boolean. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.