Add the possibility to keep the cards of some players#203
Add the possibility to keep the cards of some players#203LucasColas wants to merge 9 commits intoSirRender00:mainfrom
Conversation
|
I don't know how to how to fix that : |
|
Another thing I don't understand is about test. I have tests that fail related to |
|
@LucasColas I believe the error is from before the prehand where there is no deck attribute |
|
Yes, |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 90.97% 90.89% -0.08%
==========================================
Files 18 18
Lines 1174 1175 +1
==========================================
Hits 1068 1068
- Misses 106 107 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't understand. Whever I run |
|
Everything is good for |
Nice. I could see about adding a test when I get back from vacation next week. Feel free as well to take a crack at adding a new test case. Perhaps in the |
| if cards_players_to_keep and i in cards_players_to_keep: | ||
| game.hands[i] = cards.copy() |
There was a problem hiding this comment.
I think I would prefer to have the default be that all the player cards are the same. Here, it's that all the cards are different.
There was a problem hiding this comment.
@LucasColas Did your latest change do anything for this?
No description provided.