Support setting / getting literals in environment variables#48
Merged
sc-olenanosenko merged 3 commits intoSitecore:mainfrom Oct 12, 2023
Merged
Support setting / getting literals in environment variables#48sc-olenanosenko merged 3 commits intoSitecore:mainfrom
sc-olenanosenko merged 3 commits intoSitecore:mainfrom
Conversation
…leVariable and supporting tests
…iables due to regex subsitution vs raw interpolation
sc-olenanosenko
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds support to allow developers to explicitly choose to set environment variables as a literal (ie. wrapped in single quotes).
E.G.
Set-EnvFileVariable -Variable 'VAR4' -Value 'literal$tring' -AsLiteralWould write the following to the .env
VAR4='literal$tring'I believe this is an improvement due to:
Bonus: Also fixes a bug where the replacement of $ in Set-EnvFileVariable will result in different outcomes depending on if it was an existing variable (inserted via regex) vs a new variable (interpolated with the $'s doubled) in the .env file.