Conversation
Open
4 tasks
tranee95
previously approved these changes
May 13, 2021
Collaborator
tranee95
left a comment
There was a problem hiding this comment.
код проверил, работает, есть небольшие пожелания, но это не кретично
SavkinIS
previously approved these changes
May 16, 2021
Kibnet
requested changes
May 16, 2021
Contributor
Kibnet
left a comment
There was a problem hiding this comment.
Да, оно работает! Но код требует серьёзной доработки. Допущен ряд ошибок которые в дальнейшем могут привести к плавающим багам. Детали в комментариях.
75980b5 to
af525bc
Compare
365640b to
4b2bfcd
Compare
ffe8561 to
714e6bf
Compare
EvgeniyLyapunov
previously approved these changes
Jul 26, 2021
32cbb99 to
800edcb
Compare
Вынес присвоение статусов моим сообщениям из цикла (похоже опечатался, когда туда его засунул) Переименовал метод Поправил прыгающие галочки
Переименованы статусы "прочитано" Поправлена логика обнаружения нижнего видимого сообщения Поправлен конвертер для расстановки галочек
800edcb to
1f7ff64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.