GenerateSyntax.kt - Fix event-value array classes#15
Merged
eyesniper2 merged 1 commit intoSkriptHub:masterfrom Feb 7, 2025
Merged
GenerateSyntax.kt - Fix event-value array classes#15eyesniper2 merged 1 commit intoSkriptHub:masterfrom
eyesniper2 merged 1 commit intoSkriptHub:masterfrom
Conversation
Contributor
|
Looks great! Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr aims to fix an issue with the event-value lookup whenever an array class was provided incorrectly being checked in classinfos and returning as
Object.In addition to the fix above, it also adds an exact classinfo check which in theory should allow finer control over types of classes returned in these values.
The addition of a data class
CodeNameDatawas done to provide additional information about whether it's an array in order to correctly handle the plurality in the json (i.e.entity->entities,item->items)