Conversation
ThatGravyBoat
requested changes
Mar 27, 2026
Member
ThatGravyBoat
left a comment
There was a problem hiding this comment.
I'm not a fan of the way the stream codec wrapping is done a hook that does it for us would be better suited
src/main/kotlin/tech/thatgravyboat/skyblockapi/api/remote/api/resolvers/IdResolver.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/tech/thatgravyboat/skyblockapi/api/remote/api/SkyBlockId.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/tech/thatgravyboat/skyblockapi/api/remote/api/SkyBlockId.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/tech/thatgravyboat/skyblockapi/api/remote/api/SkyBlockId.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/tech/thatgravyboat/skyblockapi/api/remote/api/resolvers/IdResolver.kt
Outdated
Show resolved
Hide resolved
ThatGravyBoat
requested changes
Mar 27, 2026
Member
ThatGravyBoat
left a comment
There was a problem hiding this comment.
make a hook to do the streamcodec wrapping instead of creating the anonymous class in a mixin
src/main/kotlin/tech/thatgravyboat/skyblockapi/api/remote/api/resolvers/IdResolver.kt
Outdated
Show resolved
Hide resolved
ThatGravyBoat
requested changes
Mar 27, 2026
src/main/kotlin/tech/thatgravyboat/skyblockapi/api/remote/api/SkyBlockId.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/tech/thatgravyboat/skyblockapi/api/remote/api/SkyBlockId.kt
Outdated
Show resolved
Hide resolved
ThatGravyBoat
previously approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.