Skip to content

68 transition labels#69

Merged
khoadnguyen merged 4 commits intodevfrom
68-transition-labels
Oct 9, 2018
Merged

68 transition labels#69
khoadnguyen merged 4 commits intodevfrom
68-transition-labels

Conversation

@awstin17
Copy link
Copy Markdown
Collaborator

@awstin17 awstin17 commented Oct 2, 2018

Made transition labels look like the dashboard chart labels

@awstin17 awstin17 added the code review This PR is ready for code review label Oct 2, 2018
@awstin17 awstin17 added this to the Week 4 milestone Oct 2, 2018
@awstin17 awstin17 self-assigned this Oct 2, 2018
@awstin17 awstin17 requested a review from khoadnguyen October 2, 2018 04:40
@awstin17 awstin17 mentioned this pull request Oct 2, 2018
Copy link
Copy Markdown
Contributor

@khoadnguyen khoadnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, 🤚

datasets: [
{
backgroundColor: ["rgba(0,0,255, .6)", "rgba(255,0,0, .6)", "rgba(128,0,128, .6)", "rgba(0,128,0, .6)", "rgba(255,165,0, .6)", "rgba(0,128,128, .6)", "rgba(255,0,255, .6)", "rgba(0,255,0, .6)"],
backgroundColor: ["rgba(0,0,255, .2)", "rgba(255,0,0, .2)", "rgba(128,0,128, .2)", "rgba(0,128,0, .2)", "rgba(255,165,0, .2)", "rgba(0,128,128, .2)", "rgba(255,0,255, .2)", "rgba(0,255,0, .2)"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is there any reason we didn't just set the opacity to 0?

@khoadnguyen khoadnguyen merged commit e159f4a into dev Oct 9, 2018
@khoadnguyen khoadnguyen deleted the 68-transition-labels branch October 31, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code review This PR is ready for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants