Merged
Conversation
… to work with for table, so changed item content and placed display: flex for buttons instead of grid
khoadnguyen
reviewed
Oct 8, 2018
| <ion-input placeholder="Peter Horton" text-center></ion-input> | ||
| </ion-item> | ||
|
|
||
| <ion-label class= "label"color="dark">Name</ion-label> |
Contributor
There was a problem hiding this comment.
@awstin17 did some work with fontawesome icons, perhaps we could use that styling here as well?
khoadnguyen
reviewed
Oct 8, 2018
| margin: 10px 10px auto 10px; | ||
| } | ||
|
|
||
| @media screen and (min-width: 768px) { |
Contributor
There was a problem hiding this comment.
Your styling formatting and media query layout is great, can you discuss your methodology in class during CR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#45 Made profile page responsive: landscape and portrait mode for ipad; and for ipad to cell phone. Ionic components are hard to manage and work with. Spend a lot of time fixing bugs because of ionic component's predefined CSS properties.