Merged
Conversation
… login-functionality
khoadnguyen
reviewed
Oct 8, 2018
| font-size: 25px; | ||
| } | ||
|
|
||
| #email:before { |
Contributor
There was a problem hiding this comment.
Nice, you got it working, can you explain to the rest of the class how this works and what you used?
khoadnguyen
approved these changes
Oct 8, 2018
| private loginCreds : FormGroup; | ||
|
|
||
| constructor(public navCtrl: NavController, public navParams: NavParams, public _userService: UserProvider, private formBuilder: FormBuilder) { | ||
| this.loginCreds = this.formBuilder.group({ |
Contributor
There was a problem hiding this comment.
I like that this is cleaner, querying the value object. What does it return?
| constructor(public navCtrl: NavController, public navParams: NavParams) { | ||
| private loginCreds : FormGroup; | ||
|
|
||
| constructor(public navCtrl: NavController, public navParams: NavParams, public _userService: UserProvider, private formBuilder: FormBuilder) { |
Contributor
There was a problem hiding this comment.
Coordinate with @digitalkyopo on naming conventions for _user/_userService. I think you and him named it different things.
| } | ||
|
|
||
| toDashboard() { | ||
| this.navCtrl.setRoot(DashboardPage); |
Contributor
There was a problem hiding this comment.
Nice, you used this correctly. During code review, lets remind people diff b/w setRoot and push
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to login to app, added icons, added validators