Skip to content

49 register layout inconsistencies#98

Merged
khoadnguyen merged 6 commits intodevfrom
49-register-layout-inconsistencies
Oct 9, 2018
Merged

49 register layout inconsistencies#98
khoadnguyen merged 6 commits intodevfrom
49-register-layout-inconsistencies

Conversation

@jthk1106
Copy link
Copy Markdown
Contributor

@jthk1106 jthk1106 commented Oct 8, 2018

Used login page styling as reference to modify and match styling.

@jthk1106 jthk1106 added the code review This PR is ready for code review label Oct 8, 2018
@jthk1106 jthk1106 added this to the Week 4 milestone Oct 8, 2018
@jthk1106 jthk1106 self-assigned this Oct 8, 2018
@jthk1106 jthk1106 requested a review from khoadnguyen October 8, 2018 10:13
@@ -1,4 +1,41 @@
page-register {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, can you explain your approach in class and what you changed.

Copy link
Copy Markdown
Contributor

@khoadnguyen khoadnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, 🔍

@@ -112,11 +151,13 @@ page-register {
@media (min-width: 2300px) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this media query have to be here since it is empty?

@khoadnguyen khoadnguyen merged commit 07329c8 into dev Oct 9, 2018
@khoadnguyen khoadnguyen deleted the 49-register-layout-inconsistencies branch October 31, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code review This PR is ready for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants