67 register backend functionality and updates#99
Merged
khoadnguyen merged 5 commits intodevfrom Oct 9, 2018
Merged
Conversation
khoadnguyen
reviewed
Oct 8, 2018
| </ion-item> | ||
|
|
||
| <button id="register-button"color="secondary" ion-button [disabled]="!validate.valid">REGISTER </button> | ||
| <button id="register-button"color="secondary" ion-button [disabled]="!validate.valid" type="submit">REGISTER</button> |
Contributor
There was a problem hiding this comment.
Nice, I like the disabled functionality when the form is not valid. Let's re-emphasize in class this design pattern & explain its usefulness.
khoadnguyen
reviewed
Oct 8, 2018
| submitAttempt: boolean = false; | ||
|
|
||
| constructor(public navCtrl: NavController, public navParams: NavParams, private fb: FormBuilder) { | ||
| constructor(public navCtrl: NavController, public navParams: NavParams, private fb: FormBuilder, public _user: UserProvider) { |
Contributor
There was a problem hiding this comment.
Coordinate with @awstin17 to have a consistent name for the _user service.
khoadnguyen
reviewed
Oct 8, 2018
| } | ||
|
|
||
| regForm(){ | ||
| submitReg() { |
Contributor
There was a problem hiding this comment.
This could use some formatting--the indenting and format look at bit off and make it harder to read.
| @Injectable() | ||
| export class UserProvider { | ||
|
|
||
| regUrl: string = "https://j-reboot-backend.herokuapp.com/api/appUsers" |
Contributor
There was a problem hiding this comment.
This regURL seems a bit too specific for everyone's use case. Is there a better way to do this? Let's look over environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Input validators are functional, backend register is successful, navigation added to register and login buttons.