SONARJS-67 Rule: Variables should not be declared and then immediately returned or thrown#429
Merged
vilchik-elena merged 3 commits intomasterfrom Dec 23, 2016
Merged
SONARJS-67 Rule: Variables should not be declared and then immediately returned or thrown#429vilchik-elena merged 3 commits intomasterfrom
vilchik-elena merged 3 commits intomasterfrom
Conversation
…y returned or thrown
pynicolas
reviewed
Dec 22, 2016
| ], | ||
| 'project:dojo-1.8.1/dojo/dojo.js.uncompressed.js':[ | ||
| 2638, | ||
| 15035, |
b3496bf to
ecc0ca2
Compare
ecc0ca2 to
2d05f30
Compare
ghost
reviewed
Dec 23, 2016
|
|
||
| if (statements.size() > 1) { | ||
|
|
||
| StatementTree lastButOneStatement = statements.get(statements.size() - 2); |
ghost
reviewed
Dec 23, 2016
| if (initializedBindingElementTree.left().is(Kind.BINDING_IDENTIFIER)) { | ||
| String name = ((IdentifierTree) initializedBindingElementTree.left()).name(); | ||
|
|
||
| if (lastStatementReturnsVariable(lastStatement, name)) { |
There was a problem hiding this comment.
I would rename these methods returnsVariableInStatement and throwsVariableInStatement, in order to have the difference of naming at the begining of the name rather that in the middle.
ghost
reviewed
Dec 23, 2016
| if (lastStatement.is(Kind.RETURN_STATEMENT)) { | ||
| ReturnStatementTree returnStatement = (ReturnStatementTree) lastStatement; | ||
|
|
||
| if (returnStatement.expression() != null && returnStatement.expression().is(Kind.IDENTIFIER_REFERENCE)) { |
There was a problem hiding this comment.
I would factorize this part of the method, in order to have a method isVariable(ExpressionTree expr, variableName) that you can call from this method and from lastStatementThrowsVariable, instead of having two time nearly exactly the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.