SONARJAVA-3864 Update S6355 metadata#3795
Merged
dorian-burihabwa-sonarsource merged 2 commits intomasterfrom Sep 6, 2021
Merged
SONARJAVA-3864 Update S6355 metadata#3795dorian-burihabwa-sonarsource merged 2 commits intomasterfrom
dorian-burihabwa-sonarsource merged 2 commits intomasterfrom
Conversation
Contributor
Author
quentin-jaquier-sonarsource
left a comment
There was a problem hiding this comment.
The second commit contains two small code smell fixes, please rebase the two commits into master if it looks good to you.
| "ruleSpecification": "RSPEC-6355", | ||
| "sqKey": "S6355", | ||
| "scope": "All", | ||
| "defaultQualityProfiles": ["Sonar way"] |
Contributor
Author
There was a problem hiding this comment.
The rule will still be in the default profile, this line is still useless as Sonar_way_profile.json is the reference to know if a rule is in the default profile.
|
SonarQube Quality Gate
|
dorian-burihabwa-sonarsource
approved these changes
Sep 6, 2021
Contributor
dorian-burihabwa-sonarsource
left a comment
There was a problem hiding this comment.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.