Skip to content

New: Include Special option for Wanted Missing#7864

Open
mynameisbogdan wants to merge 1 commit intoSonarr:v5-developfrom
mynameisbogdan:wanted-missing-include-specials-option
Open

New: Include Special option for Wanted Missing#7864
mynameisbogdan wants to merge 1 commit intoSonarr:v5-developfrom
mynameisbogdan:wanted-missing-include-specials-option

Conversation

@mynameisbogdan
Copy link
Copy Markdown
Contributor

@mynameisbogdan mynameisbogdan commented May 17, 2025 •
edited
Loading

Description

New Special Seasons custom filter for wanted missing.

Enabled by default in the UI and v3 API, but we should make it disabled by default in v5 API @ MissingController.

Screenshots for UI Changes

Screenshot 1
Screenshot 2

@mynameisbogdan mynameisbogdan force-pushed the wanted-missing-include-specials-option branch from 930c0d8 to 84a7e8d Compare May 17, 2025 14:36
@markus101
Copy link
Copy Markdown
Member

markus101 commented May 17, 2025

Should just target this against v5, by the time it releases nothing should continue using the v3 API.

@mynameisbogdan
Copy link
Copy Markdown
Contributor Author

mynameisbogdan commented May 17, 2025

I have no issue adding a v5 controller for Missing, but apiRoot still points at v3 so the change won't do anything till refactored for React Query.

So marked as a draft till then?

@mynameisbogdan mynameisbogdan marked this pull request as draft May 17, 2025 14:44
@mynameisbogdan mynameisbogdan force-pushed the wanted-missing-include-specials-option branch from 84a7e8d to 3cccab4 Compare December 24, 2025 12:17
@mynameisbogdan mynameisbogdan marked this pull request as ready for review December 24, 2025 12:17
@mynameisbogdan
Copy link
Copy Markdown
Contributor Author

mynameisbogdan commented Dec 24, 2025

Rebased for the v5 API and react-query. 💪

markus101
markus101 requested changes Dec 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@markus101 markus101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be implemented via Custom Filters instead of an option, that'd fit more inline with what we're already doing for unmonitored episodes and be more flexible in the future.

Comment thread frontend/src/Wanted/Missing/MissingOptions.tsx Outdated
@mynameisbogdan mynameisbogdan force-pushed the wanted-missing-include-specials-option branch from 3cccab4 to e7d471e Compare December 24, 2025 18:13
@mynameisbogdan
Copy link
Copy Markdown
Contributor Author

mynameisbogdan commented Dec 24, 2025

Do you plan to do the same for the queue? Because I took inspiration from there, and it's the same as here.

@markus101
Copy link
Copy Markdown
Member

markus101 commented Dec 24, 2025

I hadn't considered that, but yeah, that makes sense. For the calendar I went straight to custom filter for excluding specials and didn't consider a separate option and forgot about this special case for the queue.

@github-actions github-actions bot added the merge-conflict PR has merge conflicts that need to be resolved before it can be merged label Dec 26, 2025
@mynameisbogdan mynameisbogdan marked this pull request as draft January 4, 2026 12:52
@mynameisbogdan mynameisbogdan force-pushed the wanted-missing-include-specials-option branch from e7d471e to 22628a0 Compare March 17, 2026 12:24
@github-actions github-actions bot removed the merge-conflict PR has merge conflicts that need to be resolved before it can be merged label Mar 17, 2026
@mynameisbogdan
Copy link
Copy Markdown
Contributor Author

mynameisbogdan commented Mar 17, 2026

I did a rebase + refactor to use custom filters, but I have a few mentions to make:

  • when you add a new custom filter with the new react-query, you get a Matching filter not found error in the console.
  • when you remove a custom filter it defaults to selectedFilterKey: 'all'
  • monitored is true by default, so if you create a new filter with just includeSpecials it's still going to filter by monitored.

@mynameisbogdan mynameisbogdan force-pushed the wanted-missing-include-specials-option branch from 22628a0 to f5d4bce Compare March 17, 2026 17:31
@mynameisbogdan mynameisbogdan marked this pull request as ready for review March 17, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markus101 markus101 Awaiting requested review from markus101

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mynameisbogdan @markus101