Skip to content

Merge branch 'UofT-DSI:main' into assignments#5

Open
Soopiona wants to merge 2 commits intomainfrom
assignment-1
Open

Merge branch 'UofT-DSI:main' into assignments#5
Soopiona wants to merge 2 commits intomainfrom
assignment-1

Conversation

@Soopiona
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

CHANGING THE CODE

What did you learn from the changes you have made?

HOW TO WRITE THE CODE IN PYTHON

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

SURELY. BUT I JUST USED MY OWN WAY.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

NOT SO MUCH

How were these changes tested?

YES

A reference to a related issue in your repository (if applicable)

NONE

Checklist

  • [ V] I can confirm that my changes are working as intended

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For part A, you’re very close—just need to make the comparison case-insensitive.
Right now "Silent" and "listen" won’t match because uppercase "S" ≠ lowercase "s".
Please revise

@Soopiona
Copy link
Copy Markdown
Owner Author

For part A, you’re very close—just need to make the comparison case-insensitive. Right now "Silent" and "listen" won’t match because uppercase "S" ≠ lowercase "s". Please revise

I've done reviewed and finished push to the branch. Thanks

Copy link
Copy Markdown
Owner Author

@Soopiona Soopiona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review points are adjusted.

@juliagallucci
Copy link
Copy Markdown

Your part A needs to be case insensitive; you can use a string method to convert all the letters to upper or lower case prior to comparing them. Pleaase revise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants