Open
Conversation
juliagallucci
approved these changes
May 6, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Great! Your code executes without error and is well commented. One suggestion would be to reduce redundancy in your code, for example a conditional statement returns a Boolean True/False, so not necessary to specify return !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
added code
What did you learn from the changes you have made?
functions and methods
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Instead of sorting the characters in each word, we could count the occurrences of each character in both words and compare the counts. If the counts for each character are the same in both words, then the words are anagrams.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
finding the method to apply
How were these changes tested?
by passing a test argument in a function
A reference to a related issue in your repository (if applicable)
Checklist