[draft] Add support for n3 style devices#546
Draft
jeinstei wants to merge 4 commits intoStreamController:mainfrom
Draft
[draft] Add support for n3 style devices#546jeinstei wants to merge 4 commits intoStreamController:mainfrom
jeinstei wants to merge 4 commits intoStreamController:mainfrom
Conversation
Contributor
Author
|
I would like some thoughts from the maintainers as to how you want to handle such things, if at all. This could be a plugin model, with a hook in DeckConfig, a check like I am doing, or a few different things depending on how layout is also included in. |
Contributor
Author
|
An option would be to have a list of "layout" classes that are matched, instead of the current DeckConfig architecture. |
Contributor
Author
|
So lets try changing this to a "layout" class, such that plugins could even register their own layout. Some sort of a dictionary with "default" being the usual layout, and others can be added and such. |
Contributor
Author
|
jeinstei
commented
Mar 6, 2026
| for device in devices: | ||
| try: | ||
| # Check if it's a StreamDeck | ||
| if device.idProduct in [ |
Contributor
Author
There was a problem hiding this comment.
This should be a new PR and automated somewhat. Especially as it is StreamDeck specific. I'll make a new PR for that separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging support for N3 layout and a framework for possibly adding other layouts.