Skip to content

Adding stroke number to rowing extension#1

Merged
MathildeJ merged 5 commits intomasterfrom
feature/AddingStrokeNumber
Feb 27, 2018
Merged

Adding stroke number to rowing extension#1
MathildeJ merged 5 commits intomasterfrom
feature/AddingStrokeNumber

Conversation

@MathildeJ
Copy link
Copy Markdown
Contributor

Adding field to specify to which stroke a trackpoint belongs (with a stroke number).
Using a null stroke number by default so that it is optional and doesn't appear in the TCX file if no strokes have been detected or if this information wasn't added.

@MathildeJ MathildeJ requested a review from truizlop February 27, 2018 12:39
Copy link
Copy Markdown
Contributor

@truizlop truizlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good PR, thanks!

@MathildeJ MathildeJ merged commit 1b7729b into master Feb 27, 2018
@MathildeJ MathildeJ deleted the feature/AddingStrokeNumber branch February 27, 2018 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants