Skip to content
This repository was archived by the owner on Aug 21, 2021. It is now read-only.

Swift 3 Migration#4

Merged
jakubvano merged 2 commits intoSwinject:masterfrom
bkobilansky:bkobilansky/swift-3-migration
Nov 14, 2016
Merged

Swift 3 Migration#4
jakubvano merged 2 commits intoSwinject:masterfrom
bkobilansky:bkobilansky/swift-3-migration

Conversation

@bkobilansky
Copy link
Contributor

Fixes #3

Notes:

  • Alamofire 4 has a minimum iOS version of 9.0, so ours had to be updated
  • Swinject pods needed to be added to test target, I was seeing linking errors
  • post_install hook to set SWIFT_VERSION 2.3 for all pods

@jakubvano
Copy link
Member

👍 Thanks for the PR! 😄
Cocoapods 1.1.0+ corectly identifies Swift version used in app, so post_install hook workaround is no longer necessary. I will remove that after merge.

@jakubvano jakubvano merged commit f411a00 into Swinject:master Nov 14, 2016
@bkobilansky bkobilansky deleted the bkobilansky/swift-3-migration branch November 19, 2016 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants