Skip to content

fix(service): isolate redis namespace for core-svc instance and properly check if project is cached#3555

Merged
Panaetius merged 6 commits intomasterfrom
hotfix/sticky-session-concurrency-error
Jul 13, 2023
Merged

fix(service): isolate redis namespace for core-svc instance and properly check if project is cached#3555
Panaetius merged 6 commits intomasterfrom
hotfix/sticky-session-concurrency-error

Conversation

@Panaetius
Copy link
Copy Markdown
Member

@Panaetius Panaetius commented Jul 11, 2023

with sticky sessions, users could get routed to services that don't have a cached copy of a project, but redis would still say there is a cache.

This isolates redis on a per-service level and also handles the case where a project is in redis but not on disk.

/deploy #persist

@Panaetius Panaetius temporarily deployed to renku-ci-rp-3555 July 11, 2023 11:34 — with GitHub Actions Inactive
@RenkuBot
Copy link
Copy Markdown
Contributor

You can access the deployment of this PR at https://renku-ci-rp-3555.dev.renku.ch

olevski
olevski previously approved these changes Jul 11, 2023
@Panaetius Panaetius temporarily deployed to renku-ci-rp-3555 July 11, 2023 11:47 — with GitHub Actions Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-3555 July 11, 2023 13:03 — with GitHub Actions Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-3555 July 11, 2023 13:18 — with GitHub Actions Inactive
@Panaetius Panaetius force-pushed the hotfix/sticky-session-concurrency-error branch from 6415f08 to 0f4f4be Compare July 12, 2023 12:09
@Panaetius Panaetius temporarily deployed to renku-ci-rp-3555 July 13, 2023 08:35 — with GitHub Actions Inactive
olevski
olevski previously approved these changes Jul 13, 2023
@Panaetius Panaetius temporarily deployed to renku-ci-rp-3555 July 13, 2023 09:10 — with GitHub Actions Inactive
@olevski olevski self-requested a review July 13, 2023 11:35
olevski
olevski previously approved these changes Jul 13, 2023
@Panaetius Panaetius force-pushed the hotfix/sticky-session-concurrency-error branch from 8bfe1af to db481bb Compare July 13, 2023 13:28
@Panaetius Panaetius deployed to renku-ci-rp-3555 July 13, 2023 13:28 — with GitHub Actions Active
@olevski olevski self-requested a review July 13, 2023 15:33
@Panaetius Panaetius enabled auto-merge (squash) July 13, 2023 15:33
@Panaetius Panaetius merged commit 4288ada into master Jul 13, 2023
@Panaetius Panaetius deleted the hotfix/sticky-session-concurrency-error branch July 13, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants