Skip to content

fix: properly remove activities in workflow remove if catalog is corrupt #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Panaetius merged 1 commit into from
Jul 11, 2024
Merged

fix: properly remove activities in workflow remove if catalog is corrupt #3729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions renku/infrastructure/gateway/activity_gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,10 @@ def _index_activity(activity: Activity, database: Database):

def _unindex_activity(activity: Activity, database: Database):
"""Add an activity to database indexes and create its up/downstream relations."""
# there are cases where the activity catalog can be corrupt and removing activities doesn't actually remove them
# here we reindex them so removal works as expected
reindex_catalog(database)

upstreams = set()
downstreams = set()

Expand Down