Skip to content

fix: add default filter to breadcrumbs configuration title to prevent ScalarDataBag exception#18933

Merged
TheMilek merged 1 commit intoSylius:2.1from
camilleislasse:fix/breadcrumbs-missing-title-default
Mar 25, 2026
Merged

fix: add default filter to breadcrumbs configuration title to prevent ScalarDataBag exception#18933
TheMilek merged 1 commit intoSylius:2.1from
camilleislasse:fix/breadcrumbs-missing-title-default

Conversation

@camilleislasse
Copy link
Copy Markdown
Contributor

@camilleislasse camilleislasse commented Mar 21, 2026

Q A
Branch? 2.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes Sylius/Stack#354
License MIT

Description

When the configuration.title is not set in the hookable metadata, accessing it directly on a ScalarDataBag throws an exception. Adding |default('') prevents the crash.

@camilleislasse camilleislasse requested review from a team as code owners March 21, 2026 18:05
@probot-autolabeler probot-autolabeler Bot added the Admin AdminBundle related issues and PRs. label Mar 21, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 21, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4e9067fe-fef4-4339-9bbe-042a5486796c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can validate your CodeRabbit configuration file in your editor.

If your editor has YAML language server, you can enable auto-completion and validation by adding # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json at the top of your CodeRabbit configuration file.

@camilleislasse camilleislasse mentioned this pull request Mar 21, 2026
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 21, 2026 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@TheMilek TheMilek merged commit 1994c3d into Sylius:2.1 Mar 25, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic425 loic425 loic425 approved these changes

@TheMilek TheMilek TheMilek approved these changes

Assignees

No one assigned

Labels

Admin AdminBundle related issues and PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camilleislasse @loic425 @TheMilek