Skip to content

Enhancement: Allow multiple task links in the PR description#16

Merged
miguelbemartin merged 6 commits intomasterfrom
enhancement/multiple-tasks
Sep 19, 2020
Merged

Enhancement: Allow multiple task links in the PR description#16
miguelbemartin merged 6 commits intomasterfrom
enhancement/multiple-tasks

Conversation

@rafaeljusto
Copy link
Contributor

@rafaeljusto rafaeljusto commented Sep 17, 2020

Resolves #2

rafaeljusto
rafaeljusto commented Sep 17, 2020
View reviewed changes
miguelbemartin
miguelbemartin suggested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@miguelbemartin miguelbemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Only a small minor change.

@rafaeljusto
Copy link
Contributor Author

rafaeljusto commented Sep 18, 2020

@miguelbemartin Thanks for reviewing and detecting the issues! 😄

I was checking the new CONTRIBUTING file, and it's not clear to me how to test the code from this PR using the act tool. If I understood correctly I need to run it inside a repository that has the .github/workflows/ files, but how would it link with the changes of this PR? 🤔 Do we have a special demo repository somewhere with the events/pull_request_opened.json file?

Thanks and sorry for about the many questions. First time playing with this 🙂 .

@miguelbemartin
Copy link
Contributor

miguelbemartin commented Sep 18, 2020

@miguelbemartin Thanks for reviewing and detecting the issues! 😄

I was checking the new CONTRIBUTING file, and it's not clear to me how to test the code from this PR using the act tool. If I understood correctly I need to run it inside a repository that has the .github/workflows/ files, but how would it link with the changes of this PR? 🤔 Do we have a special demo repository somewhere with the events/pull_request_opened.json file?

Thanks and sorry for about the many questions. First time playing with this 🙂 .

I didn't get the time to finish the contributing guide. There are missing the files to simulate the Github events.

@rafaeljusto
Copy link
Contributor Author

rafaeljusto commented Sep 18, 2020

The changes were tested by Miguel locally and worked. Moving to a regular PR.

@rafaeljusto rafaeljusto marked this pull request as ready for review September 18, 2020 10:28
miguelbemartin
miguelbemartin approved these changes Sep 19, 2020
View reviewed changes
Copy link
Contributor

@miguelbemartin miguelbemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally again and it works as expected 👍
Thanks, @rafaeljusto for your first contribution.

@miguelbemartin miguelbemartin merged commit bf14f3d into master Sep 19, 2020
@miguelbemartin miguelbemartin deleted the enhancement/multiple-tasks branch September 19, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@miguelbemartin miguelbemartin miguelbemartin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow more than one link

2 participants

@rafaeljusto @miguelbemartin