Skip to content

Minor code improvements#17

Merged
lamhoangtung merged 3 commits intomasterfrom
linus_dev
Sep 29, 2020
Merged

Minor code improvements#17
lamhoangtung merged 3 commits intomasterfrom
linus_dev

Conversation

@lamhoangtung
Copy link
Copy Markdown
Contributor

@lamhoangtung lamhoangtung commented Sep 29, 2020

Remove dead code (js + html + css). And compress them:

@lamhoangtung lamhoangtung added the enhancement New feature or request label Sep 29, 2020
@lamhoangtung lamhoangtung requested a review from hiro-v September 29, 2020 11:34
@lamhoangtung lamhoangtung self-assigned this Sep 29, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 29, 2020

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   49.46%   49.46%           
=======================================
  Files          44       44           
  Lines        3613     3613           
=======================================
  Hits         1787     1787           
  Misses       1826     1826           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d82cfda...9578173. Read the comment docs.

Copy link
Copy Markdown

@hiro-v hiro-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Accepted

@lamhoangtung lamhoangtung merged commit 12c52cd into master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove + compress js files Compress css files Merge conflict not resolved yet

2 participants